Skip some more notification data items if they are blank #5041
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Feb 10, 2025
|
Thanks so much. I'm not overly familiar with the update cycle of the app. Will this appear in the change notes of a future update? |
|
No, bugfixes will generally not be called out in release notes. We did mark another beta for release after merging this so it should be available within a day or two from Google Play (version 2025.2.3 of the app). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5038
Previously FCM would omit blank keys. This was changed and is now in line with websocket notifications, but in some places the behavior might be unexpected. This PR ignores a couple more keys if blank (like we already do for many) where it seems safe to do so.
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes
Testing note: if you try to send nothing from dev tools it will send a string
null, so send a blank string""instead