Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new configuration structure #445

Merged
merged 9 commits into from
Jun 25, 2020
Merged

feat: new configuration structure #445

merged 9 commits into from
Jun 25, 2020

Conversation

Shinigami92
Copy link
Contributor

@Shinigami92 Shinigami92 commented Jun 2, 2020 •
edited
Loading

BREAKING CHANGE: Rules have a new structure

Short description of what this resolves:

ref #279

Proposed changes:

#279 (comment)

Tasks:

  • "extends": ["htmlhint:recommended"]
  • "defaultSeverity": "error"
  • "htmlVersion": "html5"
  • "rules": {/.../} (currently not in it's own property)
  • "exclude": ["test/**/*.html"]

I think I will build the other tasks in other PRs

@Shinigami92 Shinigami92 added the feature request Functionality that introduces a new feature label Jun 2, 2020
@Shinigami92 Shinigami92 self-assigned this Jun 2, 2020
@Shinigami92 Shinigami92 changed the title feat: new condiguration structure feat: new configuration structure Jun 2, 2020
@Shinigami92 Shinigami92 marked this pull request as ready for review June 3, 2020 19:00
@Shinigami92 Shinigami92 linked an issue Jun 3, 2020 that may be closed by this pull request
Rewrite configuration structure #279
Open
8 tasks
@Shinigami92 Shinigami92 merged commit 0c55a30 into beta Jun 25, 2020
@Shinigami92 Shinigami92 deleted the feat/configuration-structure branch June 25, 2020 17:54
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
9c4e4ce 
# [0.15.0-beta.1](v0.14.0...v0.15.0-beta.1) (2020-06-25)

### Features

* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.15.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedaviddias thedaviddias added the released on @beta The issue was released on the beta branch label Jun 25, 2020
Shinigami92 added a commit that referenced this pull request Jun 25, 2020
feat: new configuration structure (#445)
ae99648 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
Shinigami92 pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
d957ece 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
a657db3 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
25ccc08 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
e640097 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
221c789 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
324decd 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
c694662 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
145ffae 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
b670c8c 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
138b128 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
8f8908e 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
6b64310 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
d5fb704 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
4743cc7 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
a11493d 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
38a07df 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
4d16458 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
df5990d 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Bug Fixes

* fix circular beta release ([dbc5efc](dbc5efc))

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
ed946f6 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Bug Fixes

* fix circular beta release ([dbc5efc](dbc5efc))

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
8478184 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Bug Fixes

* fix circular beta release ([dbc5efc](dbc5efc))

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
aea6813 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Bug Fixes

* fix circular beta release ([dbc5efc](dbc5efc))
* remove duplicate changelog ([#474](#474)) ([cfb015b](cfb015b))

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jun 25, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
2ef9f1e 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-06-25)

### Bug Fixes

* fix circular beta release ([dbc5efc](dbc5efc))
* remove duplicate changelog ([#474](#474)) ([cfb015b](cfb015b))

### Continuous Integration

* trigger major bump ([f6de930](f6de930))

### Features

* new configuration structure ([#445](#445)) ([ae99648](ae99648))

### BREAKING CHANGES

* Rules have a new structure
Shinigami92 added a commit that referenced this pull request Jun 30, 2020
feat: new configuration structure (#445)
ed7c797 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
Shinigami92 pushed a commit that referenced this pull request Jun 30, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
d7bc7cc 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
Shinigami92 added a commit that referenced this pull request Jul 8, 2020
feat: new configuration structure (#445)
91bf3e4 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
Shinigami92 pushed a commit that referenced this pull request Jul 8, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
6eae48d 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
Shinigami92 added a commit that referenced this pull request Jul 10, 2020
feat: new configuration structure (#445)
427669a 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
Shinigami92 pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
e01edc3 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
Shinigami92 added a commit that referenced this pull request Jul 10, 2020
feat: new configuration structure (#445)
0b007b3 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
Shinigami92 pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
17019f2 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
c430ea5 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([4e17338](4e17338))

### Continuous Integration

* trigger major bump ([be0b2af](be0b2af))

### Features

* move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
598f5c6 
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([4e17338](4e17338))

### Continuous Integration

* trigger major bump ([be0b2af](be0b2af))

### Features

* move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
00ec7ee 
# [0.15.0-beta.1](v0.14.1...v0.15.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([93eb5c8](93eb5c8))

### Features

* move rules into dedicated attribute ([#476](#476)) ([4d37821](4d37821))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
@semantic-release-bot
chore(release): 0.15.0-beta.1 [skip ci]
15b0b2d 
# [0.15.0-beta.1](v0.14.1...v0.15.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([93eb5c8](93eb5c8))

### Features

* move rules into dedicated attribute ([#476](#476)) ([4d37821](4d37821))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))
@bastienmoulia
Copy link
Contributor

Any hint on how to test the beta?
I try to replace the content of my .htmlhintrc file with something like:

{
  "extends": ["htmlhint:recommended"],
  "defaultSeverity": "error",
  "htmlVersion": "html5",
  "rules": {
    "alt-require": ["error"]
  }
}

No error was generated with <img src="test.jpg" />

thedaviddias pushed a commit that referenced this pull request Jun 14, 2021
@thedaviddias
feat: new configuration structure (#445)
2443bc5 
* feat: rebuild ruleset interface

* feat: update default ruleset

* feat: check is rule enabled

* feat: pass reporter message callback to init

* feat: implement new options

* feat: bind reporter to callback

* feat: update tests

* feat: fix inline comments

* feat: fix test
thedaviddias added a commit that referenced this pull request Jun 14, 2021
@thedaviddias
chore(release): 0.15.0-beta.1 [skip ci]
b6d6f53 
* new configuration structure ([#445](#445)) ([0c55a30](0c55a30))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedaviddias thedaviddias thedaviddias approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
feature request Functionality that introduces a new feature released on @beta The issue was released on the beta branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite configuration structure
3 participants
@Shinigami92 @thedaviddias @bastienmoulia