Skip to content

Commit

Permalink
Update TypeScript & typedoc to fix Node type errors, drop Node 14 in CI
Browse files Browse the repository at this point in the history
Node 14 is still nominally supported at runtime (for now), but no longer
supported at build time due to requirements of dev tooling (e.g.
typedoc)
  • Loading branch information
pimterry committed Sep 25, 2024
1 parent 70af63e commit 4f79ee5
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 56 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x, v20.11.1, 22.x]
node-version: [16.x, 18.x, 20.x, v20.11.1, 22.x]

steps:
- uses: actions/checkout@v4
Expand Down
48 changes: 0 additions & 48 deletions custom-typings/asynciterator.d.ts

This file was deleted.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@
"tmp-promise": "^1.0.3",
"ts-loader": "^9.2.9",
"ts-node": "^10.9.2",
"typedoc": "^0.22.4",
"typescript": "4.7.4",
"typedoc": "^0.26.7",
"typescript": "5.6.2",
"url": "^0.11.0",
"util": "^0.12.4",
"webpack": "^5.72.0",
Expand Down
1 change: 1 addition & 0 deletions src/rules/requests/request-rule-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
FileHandlerDefinition,
JsonRpcResponseHandlerDefinition,
ResetConnectionHandlerDefinition,
CallbackResponseMessageResult
} from "./request-handler-definitions";
import { MaybePromise } from "../../util/type-utils";
import { byteLength } from "../../util/util";
Expand Down
7 changes: 2 additions & 5 deletions typedoc.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
{
"validation": {
"invalidLink": true
},
"treatWarningsAsErrors": true,
"excludePrivate": true,
"treatValidationWarningsAsErrors": true,
"excludeProtected": true,
"excludeInternal": true,
"excludeExternals": true,
"readme": "docs/api-docs-landing-page.md",
"out": "typedoc/"
}

0 comments on commit 4f79ee5

Please sign in to comment.