Bump up dependencies. #86
Conversation
|
Should fix #84 |
xiaodong-izettle
force-pushed
the
bump-up-dependencies
branch
from
3d0a834 to
fcc6f2c
Compare
|
F.Y.I @alorlea. |
xiaodong-izettle
force-pushed
the
bump-up-dependencies
branch
2 times, most recently
from
8128b8a to
61be999
Compare
| import org.assertj.core.api.Assertions; | ||
| import org.junit.Test; | ||
|
|
||
| public class NoopTransformerTest { |
There was a problem hiding this comment.
Added this so that test coverage does not decrease....
xiaodong-izettle
force-pushed
the
bump-up-dependencies
branch
from
61be999 to
a63fce9
Compare
xiaodong-izettle
force-pushed
the
bump-up-dependencies
branch
from
a63fce9 to
0995817
Compare
| @@ -198,4 +198,11 @@ public void shouldBuildWithUdpSender() throws Exception { | |||
|
|
|||
| assertThat(getField(influxDb, InfluxDbUdpSender.class, "socketTimeout")).isEqualTo(3000); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldSetProtocolAndDefaultToHttp() { | |||
There was a problem hiding this comment.
Added this so that test coverage does not decrease.... 😄
|
This looks good to merge, FYI @eranharel |
|
Thanks for merging, @alorlea. 😄 |
|
Cool 🍰 @xiaodong-izettle and @alorlea . A question though -- is this backwards compatible with older versions of dropwizard and dropwizard-metrics v3? If not then let's do a major version upgrade for the next version release! |
|
@nzroller, v4 changed some package names stuff, so probably not completely backward compatible IMHO. I agree with you that we need a major version upgrade for the next version release. 👍 |
| @@ -37,14 +37,13 @@ | |||
| </modules> | |||
|
|
|||
| <properties> | |||
| <dropwizard.version>1.0.0</dropwizard.version> | |||
| <dropwizard.version>1.3.1</dropwizard.version> | |||
There was a problem hiding this comment.
The current latest io.dropwizard.metrics is 4.0.x
|
Hi 😄 When are you planning to release a new version? This PR removes the This will be quite useful when you have another SLF4J binding in your project 👍 |
|
Hehe, sorry for the delay, @ihmabreu. Now it's out, enjoy and have fun. 😄 |
Ping @nzroller and @ngong, thanks.