Fix issues with history navigation - entries not getting selected correctly, duplicate text in decompiler output #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following two (related) issues:
This PR changes
TreeFlattener
to implementIList<object>
.The cause of the issue is the following line in Avalonia: SelectionModel.cs#L36
Specifically, when changing the selection programmatically, the
SelectionModel
tries to find the indices of any entries added to the selection in the source, to generate the ranges. However, since the source is casted toIEnumerable<object>
here, casting theTreeFlattener
results innull
, causing theSelectionModel
to abort updating the selection.'Might be superseded by:
Looks like an update to Avalonia might fix this issue: ba7e8a2
It seems like the current master branch uses
IEnumerable
instead ofIEnumerable<T>
, which should sidestep the problem.