Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard navigation in mobile web (Issue #2159) #2166

Merged
merged 10 commits into from
Oct 13, 2022
Merged

Keyboard navigation in mobile web (Issue #2159) #2166

merged 10 commits into from
Oct 13, 2022

Commits on Oct 11, 2022

  1. feat: update testing-library/jest-dom + testing-library/react + testi… 

    …ng-library/user-event to allow better a11y testing
    @LMulvey
    LMulvey committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a58318e View commit details
    Browse the repository at this point in the history

  2. feat(Header): improve keyboard accessibility with Header

    @LMulvey
    LMulvey committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    5467b7b View commit details
    Browse the repository at this point in the history

  3. feat(Header): Trap focus on mobile navbar while it is open

    @LMulvey
    LMulvey committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    213746c View commit details
    Browse the repository at this point in the history

  4. test: update tests to use new @testing-library/user-event API

    @LMulvey
    LMulvey committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    52bb84b View commit details
    Browse the repository at this point in the history

  5. chore: properly lint code and update to please the linter

    @LMulvey
    LMulvey committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4c11f3e View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. fix: change desktop displayLinks to use short-circuit evaluation 

    Co-authored-by: Julia Nguyen <[email protected]>
    @LMulvey @julianguyen
    LMulvey and julianguyen authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f8b591b View commit details
    Browse the repository at this point in the history

  2. feat: lift up useFocusTrap hook for Modal and Header + fix Header foc… 

    …us trapping bug
    @LMulvey
    LMulvey committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b148a74 View commit details
    Browse the repository at this point in the history

  3. fix(useFocusTrap): update filtering strategy to only filter display: … 

    …none from focusable elements
    @LMulvey
    LMulvey committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3be61b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. test(InputTextarea*): remove use of Promise.all and replace with forE… 

    …ach + waitFor
    @LMulvey
    LMulvey committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    699af39 View commit details
    Browse the repository at this point in the history

  2. test(InputSwitch): update test and resolve Todo regarding use of RTL … 

    …fireEvent
    @LMulvey
    LMulvey committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    15dc31d View commit details
    Browse the repository at this point in the history