Added support for BYSETPOS #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349
rebased against master -- its been 4 years
This was a holdover from the original PR back in 2016. TimeUtil has since been refactored to not need this, but the require was inadvertently left.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was written and submitted as a ice-cube-ruby#449 upstream in 2019 and updated last in January 2023.
We pulled those changes, applied a couple of other fixes from testing and until upstream merges this change, we'll need to maintain it ourselves.
Followup: update the app to pull from this repo instead of rubygems.