Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] order: ensure arcane imports do not cause undefined behavior #3128

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Xunnamius
Copy link
Contributor

@Xunnamius Xunnamius commented Dec 23, 2024

Depends on #3127

This PR implements in import/order: a fix to ensure NaN is never passed into rank-computing functions, which can result in undefined behavior.

A demo package containing this fix is temporarily available for easy testing:

npm install --save-dev eslint-plugin-import@npm:@-xun/eslint-plugin-import-experimental

Ensure strange imports do not cause strange behavior

There are certain edge cases where a NaN rank gets passed around, such as using an import with an absolute specifier under certain configurations. The fix concerns the computeRank function.

This PR includes a unit test to catch potential regressions.

@Xunnamius Xunnamius changed the title [New] order: ensure arcane imports do not cause undefined behavior [Fix] order: ensure arcane imports do not cause undefined behavior Dec 23, 2024
@ljharb ljharb marked this pull request as draft December 23, 2024 04:40
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good overall, assuming the test fails without the fix :-)

src/rules/order.js Outdated Show resolved Hide resolved
@Xunnamius Xunnamius force-pushed the contrib-nan-bugfix branch 2 times, most recently from 64ccfb5 to a77d6b4 Compare January 22, 2025 00:19
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (668d493) to head (40cf277).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   95.62%   95.65%   +0.02%     
==========================================
  Files          83       83              
  Lines        3636     3658      +22     
  Branches     1284     1305      +21     
==========================================
+ Hits         3477     3499      +22     
  Misses        159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunnamius Xunnamius marked this pull request as ready for review January 22, 2025 02:51
@Xunnamius

This comment was marked as resolved.

@ljharb ljharb marked this pull request as draft January 22, 2025 06:01
@Xunnamius Xunnamius force-pushed the contrib-nan-bugfix branch 3 times, most recently from 02d0ab1 to 40cf277 Compare January 26, 2025 07:20
@ljharb ljharb marked this pull request as ready for review January 29, 2025 07:03
@ljharb ljharb force-pushed the contrib-nan-bugfix branch from 40cf277 to 5e7ea1d Compare January 29, 2025 07:05
@ljharb ljharb merged commit 5e7ea1d into import-js:main Jan 29, 2025
341 of 342 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants