This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Types matching #741
Open
Types matching #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviau
reviewed
Jul 29, 2019
| @@ -21,3 +21,4 @@ docs/build/ | |||
| .coverage | |||
| cover | |||
| env | |||
| .vscode | |||
There was a problem hiding this comment.
This should be in your system's global .gitignore.
It does not make sense to add every single file created by every single editor in existence to every single project's gitignore.
Look at this article for help on ignoring files with git.
|
Thanks for contributing! Please add a test so that we consider to merge the patch. Also, please make it optional as it could bread existing uses of the library. |
sebito91
suggested changes
Apr 10, 2020
There was a problem hiding this comment.
I'd like to think about merging these changes with the changes from #779, especially since you're adding a SHOW FIELD KEYS function.
We should split out the SHOW FIELD KEYS to a separate function, but I like the idea of returning the dict with types for each key.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function into write_points to get fields types of measurement, before downloading, and if field exists, convert to existed type.
This feature is very usefull if you don't care about typing your date, when download and can will avoid error with types mismatch if you try to load float into integer field.
P.S. As bonus I add VSCode files into gitignore.