Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.amqp_consumer): Allow specification of queue arguments #16141

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

n1b0r
Copy link

@n1b0r n1b0r commented Nov 5, 2024

Summary

Allow specification of queue arguments

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16140

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 5, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@n1b0r n1b0r changed the title enable queue_arguments configuration and forward it to QueueDeclare*() feat(inputs.amqp_consumer) : enable queue_arguments configuration and forward it to QueueDeclare*() Nov 5, 2024
@n1b0r n1b0r force-pushed the 16140-amqp-consumer-queue-argument branch from 61a724f to 6aaf3b6 Compare November 5, 2024 08:49
@DStrand1 DStrand1 self-assigned this Nov 5, 2024
@DStrand1
Copy link
Member

DStrand1 commented Nov 5, 2024

@n1b0r Thanks for the PR! Could you sign the CLA, run make lint and also comment in your PR description that no AI generated code was used in this PR? Thanks!

@n1b0r
Copy link
Author

n1b0r commented Nov 5, 2024

!signed-cla

@n1b0r
Copy link
Author

n1b0r commented Nov 5, 2024

Hello, I signed the CLA, make lint does not change anything, and I commented the PR about AI. I am not sure why some circleci tests are failing. Should I do something about it ?

@n1b0r n1b0r changed the title feat(inputs.amqp_consumer) : enable queue_arguments configuration and forward it to QueueDeclare*() feat(inputs.amqp_consumer): enable queue_arguments configuration and forward it to QueueDeclare*() Nov 7, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 7, 2024
@DStrand1
Copy link
Member

Could you add this field to the sample config and readme as well? Thanks!

@telegraf-tiger
Copy link
Contributor

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Nov 13, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 13, 2024
@srebhan
Copy link
Member

srebhan commented Nov 14, 2024

@n1b0r please restore the original PR description with the checkbox! It's there for a reason...

@srebhan srebhan changed the title feat(inputs.amqp_consumer): enable queue_arguments configuration and forward it to QueueDeclare*() feat(inputs.amqp_consumer): Allow specification of queue arguments Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amqp_consumer input : allow queue arguments from config
3 participants