Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fr to languageswitcher #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Fr to languageswitcher #13

wants to merge 1 commit into from

Conversation

nutsflag
Copy link
Contributor

@nutsflag nutsflag commented Apr 7, 2019

No description provided.

wei
wei reviewed Apr 7, 2019
View reviewed changes
Copy link
Member

@wei wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of redudency here. Could you simplify it and make it extendible for new languages?

@nutsflag
Copy link
Contributor Author

nutsflag commented Apr 7, 2019

Hi @wei, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wei wei wei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nutsflag @wei