Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the error not display when yaml file is incorrect #82

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix the error not display when yaml file is incorrect #82

merged 1 commit into from
Jan 16, 2025

Conversation

reidliu41
Copy link
Contributor

bjhargrave
bjhargrave requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add a test case to ensure this addresses the issue and avoid future changes from accidentally removing this feature.

@reidliu41 reidliu41 force-pushed the fix-not-display-error branch from 6538609 to 7e31da6 Compare January 16, 2025 04:22
@bjhargrave bjhargrave merged commit e085ba1 into instructlab:main Jan 16, 2025
12 checks passed
@bjhargrave
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhargrave bjhargrave bjhargrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ilab taxonomy diff fails without providing a clear error message
2 participants
@reidliu41 @bjhargrave