-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire source control hooks for opened and closed documents #1414
Fire source control hooks for opened and closed documents #1414
Conversation
@isc-tleavitt @isc-hwojnick Does someone on your team want to test this change before I merge it? |
I'll volunteer @isc-hwojnick for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One inline comment about whether the events should also occur on isfs-readonly
documents.
@@ -1431,6 +1439,22 @@ export async function activate(context: vscode.ExtensionContext): Promise<any> { | |||
DocumentContentProvider.getUri(doc, undefined, undefined, undefined, wsFolder.uri) | |||
); | |||
}), | |||
vscode.window.tabGroups.onDidChangeTabs((e) => { | |||
const processUri = (uri: vscode.Uri): void => { | |||
if (uri.scheme == FILESYSTEM_SCHEMA) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the events not wanted for documents coming from isfs-readonly
folders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. For example, we only show the source control menu for isfs
files. What do you think @isc-tleavitt?
It works great! Thank you guys for the quick turn around! |
This PR fixes #1405