Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3975 - Setup Actions to run unit tests and release the library #1

Merged
merged 41 commits into from
Jan 9, 2025

Conversation

alexgerardojacinto
Copy link
Collaborator

@alexgerardojacinto alexgerardojacinto commented Jan 8, 2025

Description

  • Adds the run-unit-tests.yml workflow to run the library's unit tests.
  • Adds the publish-android.yml workflow to publish the library in a Maven public repository, so that it can be consumed by our Capacitor and Cordova plugins.
    • This includes adding the publish-android.sh script and the corresponding Gradle files.
  • Updates README.md file with documentation for the library.

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-3975

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Successful runs of both actions: https://github.com/ionic-team/OSGeolocationLib-Android/actions

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

Context: At the moment, we do not have a Sonarqube license that we can use in the Ionic GitHub organization, and so we will skip these steps in the GitHub Action for the time being.

References: https://outsystemsrd.atlassian.net/browse/RMET-3771
@alexgerardojacinto alexgerardojacinto marked this pull request as draft January 8, 2025 14:19
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review January 8, 2025 15:13
@alexgerardojacinto alexgerardojacinto marked this pull request as draft January 8, 2025 15:51
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review January 8, 2025 17:09
Copy link

@OS-ricardomoreirasilva OS-ricardomoreirasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep LICENSE, README and CHANGELOG in the root folder.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/LICENSE Outdated Show resolved Hide resolved
scripts/publish-module.gradle Outdated Show resolved Hide resolved
.github/workflows/publish-android.yml Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@alexgerardojacinto alexgerardojacinto merged commit 4830b69 into development Jan 9, 2025
1 check passed
@alexgerardojacinto alexgerardojacinto deleted the feat/RMET-3975/setup-pipelines branch January 15, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants