Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add sizes for ionic theme #30018

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

feat(select): add sizes for ionic theme #30018

wants to merge 8 commits into from

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Nov 14, 2024

Issue number: internal


What is the current behavior?

The ionic theme does not have the styling for sizes.

What is the new behavior?

  • Added the size prop.
  • Defaults medium for ionic, undefined for the others.
  • Added tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 1:03am

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Nov 14, 2024
@thetaPC thetaPC marked this pull request as ready for review November 14, 2024 19:07
@thetaPC thetaPC requested a review from a team as a code owner November 14, 2024 19:07
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Non-blocking suggestion to update the size description.

core/src/components/select/select.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants