This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Improvements to dockerfile and docker-compose.yml for PHP5.6 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed provision.sh and added its steps to the Dockerfile. - Replaced mariadb service in docker-compose with official mariadb image. - Node version bumped to 10.x. - Used ondrej PHP repository instead of default APT. - Added Yarn. - Mailparse inclusion now by default with a package. - Replaced MAINTAINER directive for LABEL. - Updated docker-compose file version to 3.7. - Composer binary installed directly to /usr/local/bin. - Re-organized comments for easier read in small windows and terminals.
|
Awesome work! I had plans to move everything to the Dockerfile to leverage caching when building the image. Lack of time!!! Let's do this for the php7.3 branch (master). Thanks again for your valuable contribution! |
|
@ShinCoder Cool! I'll open the PRs for all the branches on your repo including the php7.3. Anything you'll like to add, feel free to tell me and I'll look into it. |
angelmadames
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional Notes
If this looks good to you, I can open the PRs for the other branches (specific to each PHP version).
Also, wanted to thank you for your work on this project since I have used it in a similar fashion in one of my repositories. I modified the
serve.shmethodology for something different thus I decided to just rename the project (although I mentioned you in the README.md as a source for what I did, hope you don't mind the forking skip).Any concerns please let me know!