made AWS credentials optional #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 16, 2019 14:58
ercpereda
reviewed
Aug 16, 2020
| @@ -1,6 +1,6 @@ | |||
| FROM ubuntu:18.04 | |||
|
|
|||
| RUN apt-get update && apt-get install -y --no-install-recommends curl cron awscli | |||
| RUN apt-get update && apt-get install -y --no-install-recommends curl cron awscli less vim | |||
There was a problem hiding this comment.
Why do you need less and vim?
There was a problem hiding this comment.
I suppose it was for debugging. Should probably be removed
jareware
requested changes
Oct 19, 2020
| @@ -8,7 +8,7 @@ cat <<EOF > env.sh | |||
| BACKUP_SOURCES="${BACKUP_SOURCES:-/backup}" | |||
| BACKUP_CRON_EXPRESSION="${BACKUP_CRON_EXPRESSION:-@daily}" | |||
| AWS_S3_BUCKET_NAME="${AWS_S3_BUCKET_NAME:-}" | |||
| BACKUP_FILENAME="$(date +"${BACKUP_FILENAME:-backup-%Y-%m-%dT%H-%M-%S.tar.gz}")" | |||
| BACKUP_FILENAME="\$(date +"${BACKUP_FILENAME:-backup-%Y-%m-%dT%H-%M-%S.tar.gz}")" | |||
There was a problem hiding this comment.
This doesn't look intentional, either?
Comment on lines
+25
to
+31
| if [ ! -z "$AWS_ACCESS_KEY_ID" ]; then | ||
| cat <<EOF > .aws/credentials | ||
| [default] | ||
| aws_access_key_id = ${AWS_ACCESS_KEY_ID} | ||
| aws_secret_access_key = ${AWS_SECRET_ACCESS_KEY} | ||
| EOF | ||
| fi |
There was a problem hiding this comment.
This is missing some indentation..?
|
will this be merged some time in the future, identation cannot be a big issue. |
Other problems like installing extra packages and adding incorrect escaping probably is, though. |
mpietruschka
referenced
this pull request
in pietmacom/docker-volume-backup
Mar 25, 2023
Add host check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case your docker host is a EC2 instance itself, the S3 access can be granted via IAM instance role. But this only works if AWS credentials are not passed directly to the CLI.