refactor: merge alias attributes #1913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one alias refers to another we now merge the attributes of the two aliases (when dealing with lists and maps, in the case of simple values the "parent" alias overrides the "child" alias). See jbangdev#1910
|
I think this might be right but not fully sure ... it does seem to be breaking behavior but maybe what we had before was worse. got some examples of what we solve and what we break? |
|
It's difficult, I'm not sure how many examples we have "in the wild" of aliases referring to other aliases. And then they'd both need to have arguments (or other options) defined. Only in those cases the behaviour has been changed. Thing is, I just tried it and although the PR does what it says it does, it unfortunately doesn't actually fix the problem mentioned in #1910 :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one alias refers to another we now merge the attributes of the two aliases (when dealing with lists and maps, in the case of simple values the "parent" alias overrides the "child" alias).
See #1910