Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to set the configuration #7

Open
wants to merge 3 commits into
base: BEAM-214-PARQUETIO
Choose a base branch
from

Conversation

LIQRGV
Copy link

@LIQRGV LIQRGV commented Aug 9, 2017

The configuration needed to write to GCS.
Usually it's been on core-site.xml, but this PR allow us to write it on the code.

@jbonofre
Copy link
Owner

jbonofre commented Aug 9, 2017

Thanks, much appreciated. Now that I did the 2.1.0.RC3 release, I will switch back on the IO PRs ;)

@LIQRGV
Copy link
Author

LIQRGV commented Aug 9, 2017

This pull only add configuration for the writer.
I will investigate how to add that on reader.
:)

@LIQRGV
Copy link
Author

LIQRGV commented Aug 15, 2017

Now the reader can using configuration too.

@LIQRGV
Copy link
Author

LIQRGV commented Aug 15, 2017

Here is the example of the configuration:

gsConfig = new Configuration();
gsConfig.setClass("fs.gs.impl", GoogleHadoopFileSystem.class, GoogleHadoopFileSystem.class);
gsConfig.setClass("fs.AbstractFileSystem.gs.impl", GoogleHadoopFS.class, GoogleHadoopFS.class);
gsConfig.setStrings("fs.gs.project.id", StorageOptions.getDefaultInstance().getProjectId());

jbonofre pushed a commit that referenced this pull request Sep 5, 2017
query3: Use GlobalWindow to comply with the State/Timer APIs (issue #7). Use timer for personState expiration in GlobalWindow (issue apache#29). Add trigger to GlobalWindow

query12: Replace Count.perKey by Count.perElement (issue apache#34)
Copy link
Owner

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you changed all files (without always modification). Can you please create a clean PR with only the diff ? Thanks !

@LIQRGV
Copy link
Author

LIQRGV commented Sep 19, 2017

I've create a new branch with same name and delete the old one.
Could you review it ?
Or should I open a new PR ?

@jbonofre
Copy link
Owner

Absolutely. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants