-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to set the configuration #7
base: BEAM-214-PARQUETIO
Are you sure you want to change the base?
Conversation
Thanks, much appreciated. Now that I did the 2.1.0.RC3 release, I will switch back on the IO PRs ;) |
This pull only add configuration for the writer. |
Now the reader can using configuration too. |
Here is the example of the configuration:
|
28c897b
to
3c4ee48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you changed all files (without always modification). Can you please create a clean PR with only the diff ? Thanks !
355b0a7
to
5fdc9b2
Compare
5fdc9b2
to
ee8d786
Compare
a3408ea
to
07199d6
Compare
I've create a new branch with same name and delete the old one. |
Absolutely. Thanks ! |
ee8d786
to
2b71ada
Compare
2b71ada
to
8b821da
Compare
8b821da
to
be89694
Compare
The configuration needed to write to GCS.
Usually it's been on core-site.xml, but this PR allow us to write it on the code.