Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTMQSTPR-47: Record validation example with Red Hat build of Apicurio Registry #504

Merged
merged 28 commits into from
Sep 16, 2024

Conversation

k-wall
Copy link
Collaborator

@k-wall k-wall commented Sep 3, 2024

ENTMQSTPR-48: record validation example

why: 2.8 supports record validation against JSON schemas in Apicurio Schema Registry.

Note: When testing the example, switch the image to the upstream.'s

quay.io/kroxylicious/kroxylicious:0.8.0

Copy link
Collaborator

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off to a good start @k-wall

examples/proxy/record-validation/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/cluster-ip/README.md Outdated Show resolved Hide resolved
@k-wall k-wall marked this pull request as ready for review September 4, 2024 13:01
@k-wall
Copy link
Collaborator Author

k-wall commented Sep 4, 2024

Still need to think about whether we want a version of the example that does load-balancer.

@k-wall k-wall changed the title ENTMQSTPR-47: record validation example ENTMQSTPR-47: Record validation example with Red Hat build of Apicurio Registry Sep 4, 2024
@k-wall k-wall requested a review from PaulRMellor September 4, 2024 14:42
@k-wall
Copy link
Collaborator Author

k-wall commented Sep 4, 2024

I think this is ready for review.

Copy link
Collaborator

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Keith. Few minor suggestions for consistency. Also question on using 2.7 image.

examples/proxy/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/cluster-ip/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/cluster-ip/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/load-balancer/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/cluster-ip/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/load-balancer/README.md Outdated Show resolved Hide resolved
examples/proxy/record-validation/cluster-ip/README.md Outdated Show resolved Hide resolved
@k-wall
Copy link
Collaborator Author

k-wall commented Sep 5, 2024

Looks good, Keith. Few minor suggestions for consistency. Also question on using 2.7 image.

#505 will update all the examples to 2.8.

@k-wall k-wall requested a review from franvila September 5, 2024 16:51
@k-wall
Copy link
Collaborator Author

k-wall commented Sep 5, 2024

@franvila would you be able to review this too?

@k-wall k-wall requested a review from SamBarker September 10, 2024 21:07
Copy link
Collaborator

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd like to find some way of cleaning up the snippets but that applies a lot wider than this PR and isn't required for this to be merged.

@k-wall
Copy link
Collaborator Author

k-wall commented Sep 11, 2024

I'd like to find some way of cleaning up the snippets but that applies a lot wider than this PR and isn't required for this to be merged.

I raised a couple of issues off the back of your comments.

#512
#513

Copy link
Collaborator

@franvila franvila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some small nits

k-wall and others added 18 commits September 12, 2024 15:43
The operator's default is okay.
reword the 'produce invalid records case'
use colons consistently
fix prereqs
@k-wall k-wall merged commit 3dc8b45 into jboss-container-images:amqstreams28-dev Sep 16, 2024
@k-wall k-wall deleted the ENTMQSTPR-47 branch September 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants