-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENTMQSTPR-47: Record validation example with Red Hat build of Apicurio Registry #504
ENTMQSTPR-47: Record validation example with Red Hat build of Apicurio Registry #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to a good start @k-wall
Still need to think about whether we want a version of the example that does load-balancer. |
I think this is ready for review. |
examples/proxy/record-validation/base/kafka/kafka-persistent.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Keith. Few minor suggestions for consistency. Also question on using 2.7 image.
#505 will update all the examples to 2.8. |
@franvila would you be able to review this too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'd like to find some way of cleaning up the snippets but that applies a lot wider than this PR and isn't required for this to be merged.
examples/proxy/record-validation/base/schema-registry/schema-registry-registry.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some small nits
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
The operator's default is okay.
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Reword
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
reword the 'produce invalid records case'
Co-authored-by: PaulRMellor <[email protected]>
use colons consistently
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
fix prereqs
Co-authored-by: PaulRMellor <[email protected]>
2ccb70f
to
15840a4
Compare
Signed-off-by: kwall <[email protected]>
ENTMQSTPR-48: record validation example
why: 2.8 supports record validation against JSON schemas in Apicurio Schema Registry.
Note: When testing the example, switch the image to the upstream.'s
quay.io/kroxylicious/kroxylicious:0.8.0