Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag being truncated when copying to clipboard #4232

Merged

Conversation

brunofjesus
Copy link
Contributor

@brunofjesus brunofjesus commented Feb 3, 2025

Copy the whole tag to clipboard instead of truncating to the value of TruncateCopiedCommitHashesTo.

  • PR Description
    My PR for copying the tag to clipboard was recently merged (Copy tags to clipboard #4219).
    While using LazyGit built from the latest master I noticed that some tags were being truncated, turns out it was due to a bug I introduced on that previous PR.
    Sorry for that.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Copy the whole tag to clipboard instead of truncating to the value of
TruncateCopiedCommitHashesTo.
Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesseduffield jesseduffield added the bug Something isn't working label Feb 3, 2025
@stefanhaller stefanhaller merged commit c014168 into jesseduffield:master Feb 4, 2025
14 of 15 checks passed
@brunofjesus brunofjesus deleted the fix-copy-tags-no-truncate branch February 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants