-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker workflow #70
base: master
Are you sure you want to change the base?
Conversation
@johang friendly ping, in case you didn't receive any notification |
@johang : Do you have any feedback on the PR? |
I'm not too keen on this patch. What's even the point of running it in Docker? You still need fuse on the host and your run with privileged true and apparmor unconfined so you don't get any security benefits. Also, btfs is packages in Debian so you can just apt-get install it instead of building it yourself. |
Thanks for reviewing @johang . |
This PR includes:
The former is used to build the code and create a Docker image. The latter contains the configuration (exposing FUSE from Docker is a bit tricky) to run a container from the previously built image which will mount Sintel on
/tmp/
, as described in docs. Just dodocker-compose up
as stated in docs.Using both files enabled me to develop and test #69 without needing to install any development libs or tools in my machine.
Optionally, the
Dockerfile
can also be used to create a public Docker image built from source to use as a distribution method via Automated Builds on Docker Hub. It takes just a few minutes of clicking to register and link the AB to GitHub's repo. Currently, I'm using one based off my fork successfully. I think it makes for an easy way to let people download the latest version easily.