Add editing support to the REPL, using the rustyline crate. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no binary only dependencies, and the issue requesting it was closed :( |
|
Seems like the next closest thing is an optional-but-on-by-default feature. |
jimblandy
force-pushed
the
rustyline
branch
2 times, most recently
from
9bb5493 to
0a67163
Compare
This as an optional default feature, "repl-edit".
|
@fitzgen Okay, I've made it an optional feature. Haven't done this before, so if you have style suggestions, I'm all ears. |
|
Just saw this comment, which seems like the best way to do this: rust-lang/cargo#1982 (comment) Sorry for moving goal posts... |
|
Oh, that makes total sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little weird to have the lisp crate depend on rustyline, instead of just bin/lisp.rs, but I don't know how to arrange that.