Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private or protected fish plugins #745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexmarnell
Copy link

Context

I have a specific use case where a set of fish plugins are made available internally. They are not public Github repositories. The curl command used by fisher will only fetch plugins from public repositories.

Proposed Changes

By changing the command to curl -n it can take advantage of any credentials stored in the ~/.netrc file. This may not be the best flag to have enabled by default, or perhaps goes against the spirit of sharing fish plugins publicly. An alternative could be to move this behind a variable or some other indicator to mark that a plugin is private.

Copy link
Owner

@jorgebucaran jorgebucaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include documentation.

@jorgebucaran
Copy link
Owner

@voidlock Hi, it's been some time. I'm generally fine with this minor change, but I'm just slightly worried it might pose a risk or harm to users. Thoughts?

@alexmarnell
Copy link
Author

@jorgebucaran I understand your concern. What if I updated the PR to include a mechanism similar to how Golang handles private modules with the GOPRIVATE environment variable?

Perhaps a FISHER_PRIVATE environment variable that a user can customize.

set FISHER_PRIVATE github.com/your_github_username/mysecret github.com/your_github_username/myothersecret

When fetching plugins, Fisher would scan the list provided by FISHER_PRIVATE. If it's found, it can update the curl command to include the --netrc flag.

@jorgebucaran
Copy link
Owner

Sorry for letting this sit for so long. That approach could potentially work, and I'm interested to see what you come up with first. I should've mentioned that earlier. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants