-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All: Mark event aliases as deprecated #1223
Conversation
BTW, that remark about |
I also need to remove the "Additional Notes" section. |
New version pushed. Changes:
The screenshot of the content below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks better
06c7c0a
to
8afd090
Compare
6abafeb
to
b1acff3
Compare
@timmywil in the end, I had to separate shorthand pages (I pushed The new pages for deprecated APIs are named I also added the |
4f9faf8
to
ad91aea
Compare
910eeb6
to
027012f
Compare
I migrated everything now, this is ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This seems like a good way to approach things.
This feeds on the ideas from @dmethvin from gh-972 to reuse existing event pages as they sometimes contain valuable info specific to those events but to instead use the
on
&trigger
signatures there, leaving the shorthand ones as deprecated.One difficulty with this approach is we cannot have both
on
&trigger
under a single signature, so I had to split them. In order to avoid rewriting the pages too much, I just left thetrigger
signature linking to theon
one. If we see fit, we can always split the sections better later.I'll post the screenshots of what this PR proposes below; for the current state, you can just check https://api.jquery.com/blur/.
Fixes gh-1205
TODO:
on
there, notrigger
)