Add zsh completions for fzf flags #2829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fzf executable itself did not have any completions. The colorscheme flags needs further work to get proper completion of all its options working. Currently it only works to complete the base scheme.
|
@EnginnerDog is that for or against the validity of the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fzf executable itself did not have any completions so I've added these based on the man page. Some descriptions have been abbreviated to maintain short lines.
The colorscheme flags needs further work to get proper completion of all its options working. Currently it only works to complete the base scheme. I'm still learning zsh completion so I wasn't able to figure it out yet.
This script could be installed into the
$fpathon install or manually moved to a completion directory by the user. I can try an auto install script if this looks good or add the installation steps into the README.