Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a complete example to clarify where to put the config files. #486

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dragz
Copy link

@dragz dragz commented Jun 26, 2024

A small addition to the examples. I wasted a few hours trying to figure out where to put the config files. It might save some time for others.

A little test example to make it clear how to test the setup and where to put the config.
@manics
Copy link
Member

manics commented Jun 28, 2024

Thanks, I think having a full example makes sense. What do you think about linking to our test config instead:
https://github.com/jupyterhub/jupyter-server-proxy/blob/main/tests/resources/jupyter_server_config.py

The advantage of that is it's always tested so will never go out of date, and also includes full examples for all config options.

@dragz
Copy link
Author

dragz commented Jul 2, 2024

That makes perfect sense. I can change my PR or if you want to do it yourself you can just ignore my PR. What do you prefer?

@dragz
Copy link
Author

dragz commented Jul 9, 2024

I tried copying the mentioned jupyter_server_config.py but it does not work out of the box. First it fails to launch the singleuserserver because it cannot find proxyextension. Commenting those two lines out make the server start but all test examples that shows up gives 500 internal error. All this will confuse a user trying to set this up.

@manics
Copy link
Member

manics commented Jul 20, 2024

That's a fair point! Can you change your example so that it'll work on all systems? At the moment it'll only work with anaconda. For example, import and use sys.executable

replaced the hardwired path to the python interpreter with the more generic sys.executable that should work on all platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants