feat(broker-configs): adjust edit button state in read-only mode

[spartanns]

• Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
Closes #230

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

• No need to
• Manually (please, describe, if necessary)
• Unit checks
• Integration checks
• Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
• My changes generate no new warnings (e.g. Sonar is happy)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

[github-actions]

Hi spartanns! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

[Haarolean]

@spartanns, there have been multiple inconsistencies across the app regarding the r/o mode. Are these all the changes we need?

[spartanns]

Basically, if a cluster is read only, then ALL the broker config edit functionality is disabled. Meaning nothing in broker config can be edited in cluster RO mode.

[Haarolean]

there have been issues across the app as I mentioned in #230, so the purpose of that issue is to fix these discrepancies across the whole app

[spartanns]

I tested my changes with 2 clusters in the app. One was read only the other one was not... You can take a look in this video:
Untitled Video October 16, 2024 11_18 PM.webm

In case I missed something, let me know and I'll fix it.

[Haarolean]

Once again -- the issue is not just about broker configs, it's about all the possible buttons in all the places.
For instance, in a r/o cluster restart/remove connectors options are available (they shouldn't be):

We have to check for all these things.

[spartanns]

Ahhh, okay, I didn't know that...I'll get right on it, and I'll let you know once I'm done.

[spartanns]

Okay, so I disabled the ActionsCell in connectors table in cluster RO mode:

Broker config edits are disabled as well as all topic configs. Connector creation is also disabled in RO mode.

If there's anything else, just let me know ;p

[Haarolean]

Not sure it's a good idea to apply this kind of rule for the whole component, as some elements in the dropdown might be allowed (like, r/o actions). There are also exclusions from r/o rule - see SAFE_ENDPOINTS in io/kafbat/ui/config/ReadOnlyModeFilter.java:23:

private static final Set<Pattern> SAFE_ENDPOINTS = Set.of(
      Pattern.compile("/api/clusters/[^/]+/topics/[^/]+/(smartfilters|analysis)$")
  );

So, actions related to topic analysis and smartfilters should be allowed despite being non-GET HTTP methods.

[spartanns]

Fixed. Applied additional isReadOnly check to only restart/remove connector actions.