-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce tests to check whether workqueue metrics exist #6003
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6003 +/- ##
=======================================
Coverage 48.36% 48.36%
=======================================
Files 666 666
Lines 54831 54831
=======================================
+ Hits 26519 26521 +2
+ Misses 26594 26592 -2
Partials 1718 1718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6b01038
to
78637b1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
78637b1
to
bed16d1
Compare
bed16d1
to
6890616
Compare
Note: my this PR is not fabricated, it is based on the implementation referenced from Kubernetes: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/metrics/metrics_grabber.go |
6890616
to
5462a31
Compare
@XiShanYongYe-Chang would you also help take a look, thanks |
4f067a6
to
db587db
Compare
Signed-off-by: chaosi-zju <[email protected]>
db587db
to
b17e3dd
Compare
/assign |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
introduce tests to check whether workqueue metrics exist
Which issue(s) this PR fixes:
Fixes part of #5954
Special notes for your reviewer:
Does this PR introduce a user-facing change?: