Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add cluster registration step in pull mode to installation-cli.yaml #6006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SkySingh04
Copy link
Contributor

Signed-off-by: Akash [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #5916

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2024
@SkySingh04 SkySingh04 changed the title feat : add cluster registration step in pull mode to installation workflow feat : add cluster registration step in pull mode to installation-cli.yaml Dec 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.34%. Comparing base (5bfdf61) to head (5d8cefa).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6006      +/-   ##
==========================================
+ Coverage   48.33%   48.34%   +0.01%     
==========================================
  Files         666      666              
  Lines       54858    54858              
==========================================
+ Hits        26516    26522       +6     
+ Misses      26617    26612       -5     
+ Partials     1725     1724       -1     
Flag Coverage Δ
unittests 48.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkySingh04 SkySingh04 force-pushed the karmadactlInstallationCLI branch from e94498a to 5d8cefa Compare January 18, 2025 17:37
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration karmadactl register to ci for registering PULL mode clusters
3 participants