Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 그룹 수정 커맨드 및 관련 이벤트 구현 #42

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

Coalery
Copy link
Member

@Coalery Coalery commented Dec 10, 2023

주요 변경 사항

그룹 수정 커맨드(ModifyGroupCommand)와 그 핸들러, 그리고 관련 이벤트(GroupUpdated)의 핸들러를 구현합니다.

변경 이유

기존 기능의 호환을 위함입니다.

@Coalery Coalery self-assigned this Dec 10, 2023
Copy link

github-actions bot commented Dec 10, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.74% (+6.41% 🔼)
665/878
🔴 Branches
57.52% (+10.29% 🔼)
88/153
🔴 Functions
50.2% (+8.53% 🔼)
125/249
🟡 Lines
75.52% (+6.76% 🔼)
620/821
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / GroupUpdated.ts
100% 100% 100% 100%
🟢
... / isDifferentStringArray.ts
100% 100% 100% 100%
🟢
... / ModifyGroupCommandHandler.ts
100% 71.43% 100% 100%
🟢
... / ModifyGroupCommand.ts
100% 100% 100% 100%
🟢
... / ModifyGroupCommandResult.ts
100% 100% 100% 100%
🟢
... / GroupUpdatedHandler.ts
100% 53.33% 100% 100%
🟢
... / GroupLogFactory.ts
100% 100% 100% 100%
🟢
... / IGroupLogRepository.ts
100% 100% 100% 100%
🟢
... / IGroupUpdatedMessageBuilder.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / GroupAuthorizer.ts
94.12% (-5.88% 🔻)
90.91% (-9.09% 🔻)
100%
93.75% (-6.25% 🔻)

Test suite run success

91 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 96cc957

@Coalery Coalery merged commit 5323f7a into main Dec 11, 2023
2 checks passed
@Coalery Coalery deleted the feat/modify-group branch December 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant