Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 그룹 로거를 사용하도록 수정 및 이모저모 리팩토링 #51

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

Coalery
Copy link
Member

@Coalery Coalery commented Jan 14, 2024

주요 변경 사항

#50 에서 구현한 그룹 로거를 사용하여 로그를 생성하도록 수정합니다.
이외 이모저모 리팩토링도 했어요.

변경 이유

그룹 로거 쓸려고 만들어서.. 이제 씁니다..

@Coalery Coalery self-assigned this Jan 14, 2024
@Coalery Coalery changed the title refactor: 그룹 로거를 사용하도록 수정 refactor: 그룹 로거를 사용하도록 수정 및 이모저모 리팩토링 Jan 14, 2024
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.24% (-1.08% 🔻)
753/1057
🔴 Branches
47.01% (-0.89% 🔻)
110/234
🔴 Functions
50.92% (-0.73% 🔻)
139/273
🟡 Lines
71.08% (-1.18% 🔻)
703/989
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / group.ts
81.82% (-18.18% 🔻)
100%
66.67% (-33.33% 🔻)
81.82% (-18.18% 🔻)
🟢
... / Group.ts
83% (-8% 🔻)
86.67% (-13.33% 🔻)
71.88%
83% (-8% 🔻)
🟡
... / GroupLog.ts
61.54% (-7.69% 🔻)
100%
16.67% (-16.67% 🔻)
61.54% (-7.69% 🔻)
🟢
... / ChangeGroupStateCommandHandler.ts
91.18% (-0.72% 🔻)
71.43% (+1.86% 🔼)
100%
90.91% (-0.76% 🔻)

Test suite run success

110 tests passing in 26 suites.

Report generated by 🧪jest coverage report action from a436d8e

@Coalery Coalery merged commit 267a9d1 into main Jan 14, 2024
2 checks passed
@Coalery Coalery deleted the refactor/use-group-logger branch January 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant