Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Apply genart filter for Collections on koda.art #11045

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: Apply genart filter for Collections on koda.art #11045

wants to merge 13 commits into from

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Sep 25, 2024 •
edited
Loading

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e06ef27
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6711749533d1d6000848914e
😎 Deploy Preview https://deploy-preview-11045--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jarsen136
Jarsen136 commented Oct 5, 2024
View reviewed changes
utils/env.ts
Comment on lines +1 to +6
// todo: const isArtGenDomain = ['koda.art'].includes(
// window.location.hostname,
// )
export const isArtGenDomain = location.hostname.startsWith('deploy-preview-') || ['koda.art', 'localhost'].includes(
window.location.hostname,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark: todo before merged

@Jarsen136 Jarsen136 marked this pull request as ready for review October 5, 2024 15:28
@Jarsen136 Jarsen136 requested a review from a team as a code owner October 5, 2024 15:28
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team October 5, 2024 15:28
hassnian
hassnian approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

components/collection/CollectionGrid.vue Outdated Show resolved Hide resolved
composables/useArtGenMode.ts Outdated Show resolved Hide resolved
composables/useArtGenMode.ts Outdated Show resolved Hide resolved
@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 12, 2024
@hassnian
Copy link
Contributor

@Jarsen136 one test is failing

CleanShot 2024-10-14 at 15 01 15@2x

@vikiival
Copy link
Member

ahp \ base\ mantle

Ahk is also supported

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Oct 15, 2024 •
edited
Loading

ahp \ base\ mantle

Ahk is also supported

it's not yet deployed on the ahk indexer side. @vikiival
image
image

@Jarsen136
Copy link
Contributor Author

@Jarsen136 one test is failing

CleanShot 2024-10-14 at 15 01 15@2x

Related to the ahk issue above. I will check after it's deployed.

@vikiival
Copy link
Member

@Jarsen136 one test is failing
CleanShot 2024-10-14 at 15 01 15@2x

Related to the ahk issue above. I will check after it's deployed.

https://kodadot.squids.live/stick/graphql

Already deployed :)

{
  collectionEntities(limit: 10) {
    id
    kind
  }
}

maybe soome cache?

@Jarsen136
Copy link
Contributor Author

@Jarsen136 one test is failing

Related to the ahk issue above. I will check after it's deployed.

https://kodadot.squids.live/stick/graphql

Already deployed :)

{
  collectionEntities(limit: 10) {
    id
    kind
  }
}

maybe soome cache?

Yes, should be cache. Today the query works well.

Ahk is also supported

There is still no gen_art nft in the ahk network, so I would not add it to the supported list for now as it's a default setting.

@Jarsen136 Jarsen136 marked this pull request as draft October 16, 2024 14:32
@Jarsen136 Jarsen136 marked this pull request as ready for review October 16, 2024 21:46
@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Oct 16, 2024 •
edited
Loading

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassnian hassnian hassnian approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply genart filter for Collections on koda.art
3 participants
@Jarsen136 @hassnian @vikiival