refactor(props): prefer interfaces over types

kripod · Jul 9, 2024 · 1640cfd · 1640cfd
1 parent 0aa188f
commit 1640cfd
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 22 deletions.
diff --git a/src/components/ButtonSecondary.tsx b/src/components/ButtonSecondary.tsx
@@ -2,14 +2,10 @@ import { clsx } from "clsx/lite";
 import { getResetClassName } from "css-homogenizer/reset-scoped";
 import { forwardRef } from "react";
 
-import type { Merge } from "../utils/types";
-
-export type ButtonSecondaryProps = Merge<
-  React.ComponentPropsWithRef<"button">,
-  {
-    size?: "md";
-  }
->;
+export interface ButtonSecondaryProps
+  extends React.ComponentPropsWithRef<"button"> {
+  size?: "md";
+}
 
 export const ButtonSecondary = forwardRef(function ButtonSecondary(
   { size = "md", className, ...props }: ButtonSecondaryProps,

diff --git a/src/components/Input.tsx b/src/components/Input.tsx
@@ -2,14 +2,10 @@ import { clsx } from "clsx/lite";
 import { getResetClassName } from "css-homogenizer/reset-scoped";
 import { forwardRef } from "react";
 
-import type { Merge } from "../utils/types";
-
-export type InputProps = Merge<
-  React.ComponentPropsWithRef<"input">,
-  {
-    size?: "sm";
-  }
->;
+export interface InputProps
+  extends Omit<React.ComponentPropsWithRef<"input">, "size"> {
+  size?: "sm";
+}
 
 export const Input = forwardRef(function Input(
   { size = "sm", className, ...props }: InputProps,

diff --git a/src/components/Popover.tsx b/src/components/Popover.tsx
@@ -1,7 +1,7 @@
 import { clsx } from "clsx/lite";
 import { forwardRef } from "react";
 
-export type PopoverProps = React.ComponentPropsWithRef<"div">;
+export interface PopoverProps extends React.ComponentPropsWithRef<"div"> {}
 
 export const Popover = forwardRef(function Popover(
   { className, ...props }: PopoverProps,

diff --git a/src/utils/types.ts b/src/utils/types.ts