fix(backend): parallelFor consume upstream inputs. Fixes #11520 #11627
+74
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Updated
resolveUpstreamArtifacts
to usegetDAGTasks
to allow for it parse through parallelFor DAG contexts to retrieve the appropriate producerTask. This fixes [backend] dsl.ParallelFor loop: cannot resolve the upstream artifact output of a previous pod #11520, it seems that the call with the filter toGetExecutionsInDAG
was not reverted back to the same as it is inresolveUpstreamParameters
in feat(backend): implement subdag output resolution #11196.Updated the argocompiler for the
iteratorTask
section. The additional "-loop" added to the task associated with the parallelFor DAG breaks the dependency validation that the argoworkflows API calls in the submission of the pipeline. This partially resolves [sdk] Unable to aggregate results over ParallelFor in Kubeflow V2 using V1 workarounds such as.after()
#10050 for the.after()
usage of a parallelTask. The implementation fordsl.Collected
in the backend will be coming in a follow-up PR.cc: @droctothorpe
Checklist: