Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fixes DAG status update to reflect completion of all tasks #11630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VaniHaripriya
Copy link
Contributor

Description of your changes:

This PR addresses the following issue:
Subdags are being updated as soon as the first task within the subdag completes, which is incorrect behavior. The subdag status should only be updated once all tasks have completed.

This fix ensures that the subdag status is updated only after all tasks have been executed.

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hbelmiro for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from hbelmiro and mprahl February 14, 2025 12:34
@VaniHaripriya VaniHaripriya changed the title fix(backend): fixes DAG status update to account for pending tasks fix(backend): fixes DAG status update to reflect completion of all tasks Feb 14, 2025
@VaniHaripriya VaniHaripriya force-pushed the subdag-status-update-fix branch from 90e9546 to a5e3e27 Compare February 14, 2025 12:38
@VaniHaripriya
Copy link
Contributor Author

DAG_Status_Update_Fix.mp4

Attaching a sample workflow after the fix.

@zazulam
Copy link
Contributor

zazulam commented Feb 14, 2025

@VaniHaripriya can you confirm that this change works for the oneof subdag example?

@VaniHaripriya
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants