Add helm chart configuration for --aws-vpc-tags argument

[pinkavaj]

Issue

#3904 (not solves the --aws-vpc-tag-key part due to #3889)

Description

Add the configuration options to helm chart

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pinkavaj / name: Jiří Pinkava (411778c)

[k8s-ci-robot]

Welcome @pinkavaj!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pinkavaj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pinkavaj]

It would be IMHO good to solve #3889 before this is considered to be merged.

[sarevalo2002]

Hi @pinkavaj, thanks for your contribution! Since this input is a stringMap, the input to --aws-vpc-tags in the deployment.yaml file should be handled slightly differently. They should be able to parse inputs of the form --set vpcTags.TagKey1=TagValue1,vpcTags.TagKey2=TagValue2,vpcTags.TagKey3=TagValue3. Feel free to look at how other stringMap flags are handled, such as controllerConfig.featureGates (which corresponds to --feature-gates) and defaultTags (which corresponds to --default-tags).

[pinkavaj]

@sarevalo2002

Hi @pinkavaj, thanks for your contribution! Since this input is a stringMap, the input to --aws-vpc-tags in the deployment.yaml file should be handled slightly differently. They should be able to parse inputs of the form --set vpcTags.TagKey1=TagValue1,vpcTags.TagKey2=TagValue2,vpcTags.TagKey3=TagValue3. Feel free to look at how other stringMap flags are handled, such as controllerConfig.featureGates (which corresponds to --feature-gates) and defaultTags (which corresponds to --default-tags).

Updated, the MR expects the #3954 will be merged, but should work with current code as well.

[sarevalo2002]

Hi @pinkavaj, thanks for the update! It looks good to me now. I've verified that applying a single tag (--set vpcTags.TagKey1=TagValue1) and multiple tags (--set vpcTags.TagKey1=TagValue1,vpcTags.TagKey2=TagValue2,vpcTags.TagKey3=TagValue3) correctly sets --aws-vpc-tags in the deployment file. When combined with the update in #3954, the VPC is appropriately set based on the given tags in helm. I'll loop in @shraddhabang for ok-to-test and lgtm labels.

[shraddhabang]

You dont need to update the version here. We will update it when we cut a release PR.

[pinkavaj]

Thx! Fixed.

[shraddhabang]

/ok-to-test

[shraddhabang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pinkavaj, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shraddhabang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment