Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove invalid EKS test #5239

Merged
merged 1 commit into from
Jan 9, 2025
Merged

🌱 Remove invalid EKS test #5239

merged 1 commit into from
Jan 9, 2025

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Dec 5, 2024 •
edited by k8s-ci-robot
Loading

EKS no longer allows CoreDNS to run when only a control plane exists; there are no schedulable nodes in this scenario, since users do not have access to control plane nodes.
What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The test for an EKS cluster only with a control plane and the CoreDNS addon no longer passes. This appears to be due to EKS's architecture - the control plane nodes are explicitly not available to user-managed deployments. It appears to have coincidentally worked in the past, but is no longer valid.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5237

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Remove CoreDNS check from EKS e2e after a change by AWS to EKS.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2024
@nrb
Copy link
Contributor Author

nrb commented Dec 5, 2024

/test pull-cluster-api-provider-aws-e2e-eks

Lets see if the overall EKS test suite passes now.

@nrb
Copy link
Contributor Author

nrb commented Dec 5, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor Author

nrb commented Dec 5, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Remove CoreDNS from EKS addon tests
e871b23 
While it may have worked in the past, CoreDNS no longer installs when
there is just an EKS control plane. A user must also create a nodegroup
for CoreDNS pods to be scheduled.

Signed-off-by: Nolan Brubaker <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2024
@nrb
Copy link
Contributor Author

nrb commented Dec 5, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor Author

nrb commented Dec 9, 2024

I believe the EKS failures are unrelated, have been trying to address them with #5239

@nrb nrb changed the title WIP: 🌱 Remove invalid EKS test 🌱 Remove invalid EKS test Dec 9, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
AndiDog
AndiDog reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

since the test only creates a control plane without worker nodes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

It's annoying that AWS has changed the behaviour.

The tests are failing because of this check: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/test/e2e/suites/managed/eks_test.go#L54

It could be worth adding COREDNS_ADDON_VERSION: "v1.11.1-eksbuild.8" back into the e2e config and for the e2e test to be updated to later add the addon.

Or short term just remove the check.

@nrb nrb mentioned this pull request Dec 11, 2024
Open
1 task
@richardcase
Copy link
Member

I had a look this morning and came to the same conclusion that short term we remove the coredns test (i will close #5269). Longer term we need to look at where the addon reconciliation is done.

@richardcase richardcase mentioned this pull request Jan 8, 2025
Closed
5 tasks
@richardcase
Copy link
Member

/release-note-edit

Remove CoreDNS check from EKS e2e after a change by AWS to EKS.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 9, 2025
@richardcase
Copy link
Member

I think we can merge this. But whilst we can other opionions:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@richardcase
Copy link
Member

@AndiDog also agrees that we should merge: https://kubernetes.slack.com/archives/CD6U2V71N/p1736437658486109?thread_ts=1736409127.439569&cid=CD6U2V71N

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@richardcase
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@richardcase
Copy link
Member

/override pull-cluster-api-provider-aws-e2e-eks
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-e2e-eks

In response to this:

/override pull-cluster-api-provider-aws-e2e-eks
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 0b6b8a6 into kubernetes-sigs:main Jan 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@richardcase richardcase

@AndiDog AndiDog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EKS e2e tests permanently failing
4 participants
@nrb @richardcase @k8s-ci-robot @AndiDog