Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add release 1.8 book link #11486

Merged
merged 1 commit into from
Dec 3, 2024
Merged

📖 add release 1.8 book link #11486

merged 1 commit into from
Dec 3, 2024

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of: #11092

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2024
fabriziopandini
fabriziopandini reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandankumar4 are we planning to backport this change?
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a01a1e772302d615e0cbe235d2353fc3765118d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@chandankumar4
Copy link
Contributor Author

@chandankumar4 are we planning to backport this change?

@fabriziopandini
No, we don't need to backport this change, as the 3rd point mentioned here it's only for main branch.

@chandankumar4
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
Sunnatillo
Sunnatillo reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chandankumar4
Copy link
Contributor Author

chandankumar4 commented Nov 30, 2024 •
edited
Loading

Once this PR is merged, the broken link should be fixed!!

@fabriziopandini
Copy link
Member

Once kubernetes/k8s.io#7570 PR is merged, the broken link should be fixed!!

It is merged now

@chandankumar4 chandankumar4 force-pushed the cluster-api-release-1.9-book branch 2 times, most recently from 7b95bd4 to f749053 Compare December 2, 2024 19:18
@chandankumar4
📖 add release 1.8 book link
1cd0dab 
Signed-off-by: chandankumar4 <[email protected]>
@chandankumar4 chandankumar4 force-pushed the cluster-api-release-1.9-book branch from f749053 to 1cd0dab Compare December 2, 2024 19:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@fabriziopandini
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
fabriziopandini
fabriziopandini reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 799c2314591a1c55168010eb2eba077fb97d711f

@k8s-ci-robot k8s-ci-robot merged commit 07392ce into kubernetes-sigs:main Dec 3, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 3, 2024
@chandankumar4 chandankumar4 deleted the cluster-api-release-1.9-book branch December 3, 2024 10:14
@Sunnatillo Sunnatillo mentioned this pull request Dec 4, 2024
Closed
54 tasks
@chandankumar4
Copy link
Contributor Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@chandankumar4: new pull request created: #11560

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees

@fabriziopandini fabriziopandini

@Sunnatillo Sunnatillo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@chandankumar4 @k8s-ci-robot @fabriziopandini @k8s-infra-cherrypick-robot @Sunnatillo