-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add ginkgo labels to e2e tests #11686
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM seems it already can be switched in Makefile from GINKGO_FOCUS
to --label-filter=${GINKGO_LABEL_FILTER}
with GINKGO_LABEL_FILTER ?= !skip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a nice update
/lgtm
yeah sure, i think there are a few places where we can start updating things. can do that in this PR or a followup. we would also need to make the changes in test-infra: https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/cluster-api to take full advantage of the new labels |
/lgtm |
LGTM label has been added. Git tree hash: b4c4d704a6f2f99f551f076e1464e3723f2990fb
|
What this PR does / why we need it:
adds ginkgo labels to e2e tests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9620
/area e2e-testing