Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add ginkgo labels to e2e tests #11686

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cahillsf
Copy link
Member

What this PR does / why we need it:
adds ginkgo labels to e2e tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9620

/area e2e-testing

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@cahillsf cahillsf marked this pull request as ready for review January 14, 2025 23:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM seems it already can be switched in Makefile from GINKGO_FOCUS to --label-filter=${GINKGO_LABEL_FILTER} with GINKGO_LABEL_FILTER ?= !skip?

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a nice update

/lgtm

@cahillsf cahillsf changed the title 🌱 add ginkgo labels to e2e tests 🌱 Add ginkgo labels to e2e tests Jan 15, 2025
@cahillsf
Copy link
Member Author

cahillsf commented Jan 15, 2025

LGTM seems it already can be switched in Makefile from GINKGO_FOCUS to --label-filter=${GINKGO_LABEL_FILTER} with GINKGO_LABEL_FILTER ?= !skip?

yeah sure, i think there are a few places where we can start updating things. can do that in this PR or a followup.

we would also need to make the changes in test-infra: https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/cluster-api to take full advantage of the new labels

@Danil-Grigorev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4c4d704a6f2f99f551f076e1464e3723f2990fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce ginkgo labels
4 participants