Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial support for Apache APISIX provider #108

Merged
merged 1 commit into from
Jan 8, 2024
Merged

feat: add initial support for Apache APISIX provider #108

merged 1 commit into from
Jan 8, 2024

Conversation

pottekkat
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a basic Apache APISIX provider. We will keep improving it but this is a start.

Which issue(s) this PR fixes:

Related to #107

Does this PR introduce a user-facing change?:

New Apache APISIX provider.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pottekkat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2023
mlavacca
mlavacca reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @pottekkat! It's great to have another provider onboard!

pkg/i2gw/providers/apisix/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/apisix/http_to_https.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/apisix/http_to_https.go Outdated Show resolved Hide resolved
mlavacca
mlavacca reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please add tests for the feature conversion you added? 🙂

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2023
@pottekkat
Copy link
Contributor Author

@mlavacca Added test cases and made changes as you suggested.

@pottekkat
Copy link
Contributor Author

Hello @levikobi @mlavacca is there anything else I should do here?

levikobi
levikobi reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this one @pottekkat!
This PR by itself looks good to me, but I'm afraid it's going to conflict with #116
/lgtm
/cc @LiorLieberman

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 4, 2024
@pottekkat
Copy link
Contributor Author

pottekkat commented Jan 4, 2024 •
edited
Loading

Thank you for the review @levikobi

Just fixed the lint errors in the last commit.

Should we wait till #116 is merged and make changes to this PR or merge this PR and make changes in #116?

@LiorLieberman
Copy link
Member

Should we wait till #116 is merged and make changes to this PR or merge this PR and make changes in #116?

Thanks @pottekkat!

@mlavacca should come back from vacation early next week I think, lets wait for his review on this and #116.
It is not going to be a big conflict, either me or you will incorporate the changes based on what will be submitted first.

@LiorLieberman LiorLieberman changed the title feat: initial Apache APISIX provider feat: add initial support for Apache APISIX provider Jan 4, 2024
@LiorLieberman
Copy link
Member

LiorLieberman commented Jan 4, 2024 •
edited
Loading

ok @mlavacca will be off for a bit, lets review and merge this.

I have a few general comments:

  1. I just merged [Revert the revert] Change ingress fetching to be isolated per provider #116, can you adapt your code based on this? it will be mostly similar to ingressnginx and kong but if something is unclear i am happy to help

  2. can you change all new (only new) files from 2023 in the top to 2024 (happy new year 🙂)

  3. can you click "resolve" for the comments you already resolved?

  4. can you organize / rebase your commits so they will be meaningful? we are going to squash it anyway but the commits will still appear in the description of the commit that will be merged

re request my review when its ready again

Thanks!

@pottekkat
Copy link
Contributor Author

pottekkat commented Jan 4, 2024 •
edited
Loading

Happy new year!

I have rebased to the main branch and made changes to the provider code.

Ping @LiorLieberman for review.

LiorLieberman
LiorLieberman reviewed Jan 5, 2024
View reviewed changes
pkg/i2gw/providers/apisix/resource_reader.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/apisix/http_to_https_test.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/apisix/http_to_https_test.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/apisix/http_to_https_test.go Outdated Show resolved Hide resolved
@pottekkat pottekkat force-pushed the feat/apisix-provider/1 branch from 87c933a to 2f38433 Compare January 8, 2024 12:35
@LiorLieberman
Copy link
Member

/retest

@pottekkat pottekkat force-pushed the feat/apisix-provider/1 branch from 2f38433 to fc3f115 Compare January 8, 2024 12:43
@LiorLieberman
Copy link
Member

/retest
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2024
@pottekkat pottekkat force-pushed the feat/apisix-provider/1 branch 2 times, most recently from 4998171 to e0dbcf8 Compare January 8, 2024 12:54
@pottekkat pottekkat force-pushed the feat/apisix-provider/1 branch from 2606cb8 to e314aba Compare January 8, 2024 13:13
@pottekkat
Copy link
Contributor Author

/retest

@LiorLieberman
Copy link
Member

Thanks @pottekkat

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, pottekkat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 44bb9f9 into kubernetes-sigs:main Jan 8, 2024
4 checks passed
@pottekkat pottekkat deleted the feat/apisix-provider/1 branch January 8, 2024 14:53
@pottekkat pottekkat restored the feat/apisix-provider/1 branch February 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi levikobi left review comments

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@mlavacca mlavacca Awaiting requested review from mlavacca

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@levikobi levikobi

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pottekkat @k8s-ci-robot @LiorLieberman @mlavacca @levikobi