Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kong TCPIngress translation #86

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Kong TCPIngress translation #86

merged 4 commits into from
Mar 12, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Oct 26, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #85

Additionally, go has been bumped to 1.21

Does this PR introduce a user-facing change?:

The Kong `TCPIngress` resources are properly translated into `Gateway`s, `TCPRoute`s, and `TLSRoute`s.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2023
@mlavacca mlavacca temporarily deployed to release October 26, 2023 07:19 — with GitHub Actions Inactive
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2023
@mlavacca mlavacca temporarily deployed to release October 27, 2023 17:04 — with GitHub Actions Inactive
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 27, 2023
@mlavacca mlavacca temporarily deployed to release October 30, 2023 14:04 — with GitHub Actions Inactive
@mlavacca mlavacca temporarily deployed to release October 30, 2023 15:48 — with GitHub Actions Inactive
@mlavacca mlavacca temporarily deployed to release October 30, 2023 16:49 — with GitHub Actions Inactive
@mlavacca mlavacca temporarily deployed to release October 31, 2023 08:46 — with GitHub Actions Inactive
@mlavacca mlavacca temporarily deployed to release October 31, 2023 08:51 — with GitHub Actions Inactive
@mlavacca mlavacca mentioned this pull request Nov 2, 2023
Closed
@mlavacca mlavacca marked this pull request as ready for review November 28, 2023 10:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@mlavacca
Copy link
Member Author

/retest

@mlavacca mlavacca mentioned this pull request Nov 28, 2023
Merged
levikobi
levikobi reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through some of the changes here, but as you stated at #99, we should come first to a consensus regarding the handling of InputResources.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023
@mlavacca mlavacca requested a review from LiorLieberman March 11, 2024 10:54
@mlavacca
address review comments
0155158 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca
Copy link
Member Author

/retest

LiorLieberman
LiorLieberman approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks.
Added a small request to add a comment.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@LiorLieberman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 63d1176 into kubernetes-sigs:main Mar 12, 2024
5 checks passed
xtineskim pushed a commit to xtineskim/ingress2gateway that referenced this pull request Apr 23, 2024
@mlavacca @xtineskim
Kong TCPIngress translation (kubernetes-sigs#86)
19a05be 
* feat: kong's TCPIngress conversion

Signed-off-by: Mattia Lavacca <[email protected]>

* address review comments

Signed-off-by: Mattia Lavacca <[email protected]>

* chore: pointer to storage in provider

Signed-off-by: Mattia Lavacca <[email protected]>

* chore: added comment to MergeGatewayResources

Signed-off-by: Mattia Lavacca <[email protected]>

---------

Signed-off-by: Mattia Lavacca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@levikobi levikobi Awaiting requested review from levikobi

Assignees

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Kong provider] TCPIngress translation
4 participants
@mlavacca @k8s-ci-robot @LiorLieberman @levikobi