Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: Implement in-place updates support #7673

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b583049
VPA: Add UpdateModeInPlaceOrRecreate to types
jkyros Mar 14, 2024
2b84bef
VPA: Allow admission-controller to validate in-place spec
maxcao13 Jan 7, 2025
9f703bf
VPA: Stuck in-place resizes still require eviction
jkyros Mar 14, 2024
326cbf3
VPA: Make eviction restriction in-place aware
jkyros Mar 14, 2024
45ad814
VPA: Updater logic allows in-place scaling
jkyros Mar 14, 2024
0236fb7
VPA: Add metrics gauges for in-place updates
jkyros Mar 14, 2024
38bd58e
VPA: Update mocks to accommodate in-place VPA changes
jkyros Mar 14, 2024
45f082a
VPA: hack unit tests to account for in-place
jkyros Mar 14, 2024
ff29419
VPA: Add e2e tests for in-place scaling
jkyros Mar 23, 2024
d25a609
VPA: allow rule-breaking updates if disruptionless
jkyros Mar 23, 2024
e1ca639
only allow in-place if explicitly set (for testing)
jkyros Mar 21, 2024
aec718a
VPA: Allow VPA updater to actuate recommendations in-place
maxcao13 Dec 20, 2024
f2b8124
VPA: Enable InPlacePodVerticalScaling feature flag on e2e
maxcao13 Jan 7, 2025
e406979
VPA: Add in-place actuation and admission-controller e2e tests
maxcao13 Jan 7, 2025
53d4006
VPA: fix logs and cleanup TODOs according to review
maxcao13 Jan 15, 2025
0fdfd98
fixup! VPA: Add UpdateModeInPlaceOrRecreate to types
maxcao13 Jan 15, 2025
f4ad3ca
fixup! VPA: fix logs and cleanup TODOs according to review
maxcao13 Jan 15, 2025
ac6d787
fixup! VPA: Allow VPA updater to actuate recommendations in-place
maxcao13 Jan 16, 2025
42e198e
fixup! fixup! VPA: fix logs and cleanup TODOs according to review
maxcao13 Jan 16, 2025
2fa0144
fixup! fixup! VPA: Allow VPA updater to actuate recommendations in-place
maxcao13 Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions vertical-pod-autoscaler/deploy/vpa-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,32 @@ rules:
- create
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: system:vpa-updater-in-place
rules:
- apiGroups:
- ""
resources:
- pods/resize
- pods
verbs:
- patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: system:vpa-updater-in-place-binding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: system:vpa-updater-in-place
subjects:
- kind: ServiceAccount
name: vpa-updater
namespace: kube-system
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: system:metrics-reader
Expand Down
1 change: 1 addition & 0 deletions vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ spec:
- "Off"
- Initial
- Recreate
- InPlaceOrRecreate
- Auto
type: string
type: object
Expand Down
Loading
Loading