Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.29] sig-release: change go version for go-compat jobs #34062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[1.29] sig-release: change go version for go-compat jobs #34062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.29.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1758,7 +1758,7 @@ presubmits:
- runner.sh
env:
- name: GO_VERSION
value: 1.21.4
value: 1.22.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have manually encoded go versions here anyhow? We should not be constantly PR-ing specific go versions in more places. If we're trying to test something like "use the latest patch version" we should automatically determine and use that?

Copy link
Member

@BenTheElder BenTheElder Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see: kubernetes/kubernetes#126713 (comment)

We could probably obtain that value from git but it would be slightly more complex ... and we'd still have a problem in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably obtain that value from git but it would be slightly more complex

we snapshot it from git at the point in time when the minor jobs are forked (https://github.com/kubernetes/test-infra/blob/master/releng/prepare_release_branch.py#L144) :)

less runtime indication and magic is easier to reason about, in my opinion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looked like something we'd be updating regularly, which we should dedupe. Doesn't seem worth it if it's meant to be fixed per branch, we should document this job #34062 (comment)

image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241230-3006692a6f-1.29
name: ""
resources:
Expand Down Expand Up @@ -1935,7 +1935,7 @@ presubmits:
- test
env:
- name: GO_VERSION
value: 1.21.4
value: 1.22.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

we shouldn't be bumping these up minor versions without discussion… the point is to make sure these pass on the original go minor the kubernetes minor was released on

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems right, thanks for the reminder

/lgtm cancel

image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241230-3006692a6f-1.29
name: ""
resources:
Expand Down