Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry resource deletion #460

Closed
wants to merge 2 commits into from
Closed

fix: retry resource deletion #460

wants to merge 2 commits into from

Conversation

eddycharly
Copy link
Contributor

@eddycharly eddycharly commented Jan 26, 2023 •
edited
Loading

This PR retries resource deletion.

Fixes #459

iblancasa
iblancasa suggested changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to sign off your commits.

LGTM!

@eddycharly
Copy link
Contributor Author

Closing, old one.

@eddycharly eddycharly closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancasa iblancasa iblancasa requested changes

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@asekretenko asekretenko Awaiting requested review from asekretenko

@kaiwalyajoshi kaiwalyajoshi Awaiting requested review from kaiwalyajoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deleting a resource can fail
2 participants
@eddycharly @iblancasa