Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Call driver factories from Manager.php class through the container to allow DI #54244

Closed

Conversation

Garanaw
Copy link

@Garanaw Garanaw commented Jan 18, 2025

This PR makes use of the Container to call drivers' factories in the Manager.php class rather than calling it directly. This allows devs to use dependency injection to reduce the boilerplate of their code:

Before:

class MyManager extends \Illuminate\Support\Manager
{
    public function defaultDriver()
    {
        return 'something';
    }
    
    public function makeSomethingDriver()
    {
        return new Something(
            d1: $this->container->make(Dependency1::class),
            d2: $this->container->make(Dependency2::class),
            custom: 'customParam',
        );
    }
    
    public function makeSimpleDriver()
    {
        return $this->container->make(SimpleDriver::class);
    }
}

After:

class MyManager extends \Illuminate\Support\Manager
{
    public function defaultDriver()
    {
        return 'something';
    }
    
    public function makeSomethingDriver(Dependency1 $d1, Dependency2 $d2)
    {
        return new Something(d1: $d1, d2: $d2, custom: 'customParam');
    }
    
    public function makeSimpleDriver(SimpleDriver $driver)
    {
        reutnr $driver;
    }
}

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants