Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/1173] implement fallback article images #1178

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Nathan-Cowin
Copy link
Contributor

@Nathan-Cowin Nathan-Cowin commented Nov 9, 2024

This Ticket Resolves #1173

Please see below before and after for all effected areas on desktop and mobile, very slight difference on "Show" page, due to moving to so no bg-repeat. The adjustment was minimal, so replicating the previous setup didn't seem necessary

I also hasHeroImage from the backend code as it's no longer needed as this code change will handle this logic in the view.

Overview Summary
Before:
image
image
After:
image
image

Show
Before:
image
image
After:
image
image

Summary
Before:
image
image
After:
image
image

User Summary
Before:
image
image

After:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement fallback image for article images.
1 participant