set resolution D as default DavideViolante#143

liardoecp · Oct 23, 2024 · d45fef8 · d45fef8
1 parent 95002cd
commit d45fef8
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 3 deletions.
diff --git a/TODO.md b/TODO.md
@@ -1,3 +1,2 @@
 # TODO
-- Aggiornare README.md
-- valore di default di resolution 'D'
+- Aggiornare README.md
diff --git a/src/getHistoricalData.js b/src/getHistoricalData.js
@@ -1,7 +1,7 @@
 const { mapResponse } = require('../functions');
 const { getPairId } = require('../mapping');
 
-const buildUrl = ({ input, resolution, from, to } = {}) => {
+const buildUrl = ({ input, resolution = 'D', from, to } = {}) => {
   const query = new URLSearchParams({
     symbol: getPairId(input),
     resolution,

diff --git a/test/getHistoricalData.spec.js b/test/getHistoricalData.spec.js
@@ -178,4 +178,61 @@ describe('Tests for getHistoricalData()', () => {
     ];
     expect(data).toEqual(expected);
   });
+
+  it('should use resolution \'D\' as default', async () => {
+    scope
+        .get('/d8f62270e64f9eb6e4e6a07c3ffeab0b/1729428526/9/9/16/history')
+        .query({
+          symbol: '1',
+          resolution: 'D',
+          from: 1729123200,
+          to: 1729209600,
+        })
+        .reply(200, {
+          't': [
+            1729123200,
+          ],
+          'c': [
+            1.08309996128082008937099089962430298328399658203125,
+          ],
+          'o': [
+            1.086099982261659935289799250313080847263336181640625,
+          ],
+          'h': [
+            1.0872999429702800977537435755948536098003387451171875,
+          ],
+          'l': [
+            1.0809999704360999661645337255322374403476715087890625,
+          ],
+          'v': [
+            1,
+          ],
+          'vo': [
+            'n/a',
+          ],
+          'vac': [
+            'n/a',
+          ],
+          's': 'ok',
+        });
+
+    const data = await getHistoricalData({
+      input: 'currencies/eur-usd',
+      from: new Date(1729123200000),
+      to: new Date(1729209600000),
+    });
+
+    const expected = [
+      {
+        date: 1729123200000,
+        value: 1.08309996128082008937099089962430298328399658203125,
+        price_open: 1.086099982261659935289799250313080847263336181640625,
+        price_high: 1.0872999429702800977537435755948536098003387451171875,
+        price_low: 1.0809999704360999661645337255322374403476715087890625,
+        price_close: 1.08309996128082008937099089962430298328399658203125,
+        volume: 1,
+      },
+    ];
+    expect(data).toEqual(expected);
+  });
 });