Add Flex Attention Monkey Patch for LLAMA #540
+118
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need flex attention for custom attentions/masks to achieve better performance (for example, shared prefix)
Two ways to enable flex attention in liger:
attn_implementation
ofModelConfig
from PyTorchsdpa
/eager
toflex_attention
(for instance, LlamaConfig). By doing so, we'll switchconfig._attn_implementation
to use flex attention impl.sdpa
(however now it'sflex_attention
instead).Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence