Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix convergence test for future transfomers version #546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Fix convergence test for future transfomers version #546

wants to merge 2 commits into from

Conversation

Tcc0403
Copy link
Collaborator

@Tcc0403 Tcc0403 commented Jan 29, 2025

Summary

Fix #543.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@Tcc0403 Tcc0403 marked this pull request as ready for review February 4, 2025 10:19
@Tcc0403 Tcc0403 mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The convergence test test_mini_models_with_logits is failing with the latest transformers
1 participant
@Tcc0403